Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange for cvssv3 #3861

Merged
merged 13 commits into from
Feb 20, 2021
Merged

Rearrange for cvssv3 #3861

merged 13 commits into from
Feb 20, 2021

Conversation

madchap
Copy link
Collaborator

@madchap madchap commented Feb 14, 2021

Addresses #3823 - The useful cvssv3 javascript pop-up is certainly underutilized as it's buried down the field. Bringing it up next to severity so one is actually tempted to give findings a vector string.

Edit:

image

View - pop-over severity if exists and remove the panel.

image

@damiencarol
Copy link
Contributor

could we switch to label CVSS v3 exactly ?

@damiencarol damiencarol self-requested a review February 14, 2021 18:56
@madchap
Copy link
Collaborator Author

madchap commented Feb 14, 2021

Or something like that to avoid the new row?

image

@madchap
Copy link
Collaborator Author

madchap commented Feb 14, 2021

could we switch to label CVSS v3 exactly ?

Sure, but new migration.

@madchap madchap added the New Migration Adding a new migration file. Take care when merging. label Feb 14, 2021
@madchap madchap requested review from valentijnscholten and a team February 14, 2021 23:04
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch Maffooch merged commit c04ca2b into DefectDojo:dev Feb 20, 2021
@Maffooch
Copy link
Contributor

Well that was not when I tried to do :/ got the migrations in order but the unit tests wouldn't recognize it so I tried to merge dev into this branch and got them switched.. May need to revert if that's the best idea.

@valentijnscholten
Copy link
Member

Maybe just make a new one that fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Migration Adding a new migration file. Take care when merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants