Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick report based on current finding filters #3927

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Quick report based on current finding filters #3927

merged 3 commits into from
Mar 2, 2021

Conversation

Maffooch
Copy link
Contributor

Generate a finding report very quickly with the current findings displayed on a given page with the current filters applied. No need redo the current filter options on the report tab any longer.
Screen Shot 2021-02-25 at 1 52 07 AM

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

dojo/templates/dojo/findings_list_snippet.html Outdated Show resolved Hide resolved
dojo/templates/dojo/view_test.html Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch Maffooch marked this pull request as draft February 25, 2021 08:56
@Maffooch
Copy link
Contributor Author

Rebased and the reports went from being generated in about 3 seconds to 60 seconds. Will take a look tomorrow.

@Maffooch
Copy link
Contributor Author

Maffooch commented Mar 2, 2021

Performance issues were resolved since my last commit. I suspect the release of 1.13.1 helped that out.

@Maffooch Maffooch marked this pull request as ready for review March 2, 2021 02:43
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 34f52d1 into DefectDojo:dev Mar 2, 2021
@Maffooch Maffooch deleted the report branch March 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants