jira helper: remove redundant .save() calls #3953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #3944 I realized these 2
find.save()
calls are no longer needed. Thejira_change
andjira_created
are now stored on theJIRA_Issue
model, so we're changing no data on the finding when pushing to JIRA.Removing these doesn't fix the timing issue, but reduces the impact quite a bit by not overwriting the finding with old data.