Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate to github pages #3977

Merged
merged 6 commits into from
Mar 4, 2021
Merged

docs: migrate to github pages #3977

merged 6 commits into from
Mar 4, 2021

Conversation

alles-klar
Copy link
Contributor

Migrates all links from readthedocs to github pages.

@alles-klar alles-klar added documentation New Migration Adding a new migration file. Take care when merging. labels Mar 2, 2021
@valentijnscholten
Copy link
Member

thanks, big PR!

valentijnscholten
valentijnscholten suggested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need a migration to only change a help text. it would save some migrations and the need for others to keep rebasing their migrations. wdyt? (just change the existing migration(s) for this field)

@alles-klar
Copy link
Contributor Author

Changing existing migrations usually not a good idea and can have a lot of side effects. I prefer to use our proved approach, also for small changes.

@valentijnscholten
Copy link
Member

There are no side affects if it doesn't affect the sql schema.

@damiencarol
Copy link
Contributor

damiencarol commented Mar 3, 2021 •
edited

I agree, we should remove these hard coded links to the documentation.

madchap
madchap approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@madchap madchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alles-klar !

@madchap madchap removed the New Migration Adding a new migration file. Take care when merging. label Mar 3, 2021
@madchap
Copy link
Collaborator

madchap commented Mar 3, 2021

Removing the New Migration label since there is no new migration file.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@alles-klar alles-klar merged commit 46966f0 into DefectDojo:dev Mar 4, 2021
@alles-klar alles-klar deleted the docs-migrate branch March 4, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiencarol damiencarol damiencarol left review comments

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@madchap madchap madchap approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alles-klar @valentijnscholten @damiencarol @madchap