fix counts returned to non-staff users in apiv2 #4074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4069
For non-staff users, we have queries where we filter objects based on the
authorized_users
property of the product or product type:This works OK, but will join a couple of tables and could lead to objects being in the result multiple times. This PR adds
.distinct()
to resolve this.There's also one place where we had 2 different queries for the list of findings and the count of that list.