Nexpose parser: Process all hosts + add Endpoint(and protocol) + add new reference links + test #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BID, CERT-VN, DEBIAN, XF
damiencarol
approved these changes
Mar 19, 2021
`iter` returns all children, grandchildren, ... with specific nam, what causes, duplicity in number of endpoints
valentijnscholten
approved these changes
Mar 19, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for-loop processed only last "discovered" host in the XML file. I move it to the upper loop.
There was missing also adding Endpoint - so it wasn't possible to identify where vulnerability is.
For finding on specific service, I added also a protocol name to the Endpoint
I also added a couple of new references used in Nexpose reports.
Test XML changed to easier readable.
+ Using better names of variables
+ Tests