Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title max length and add more tests #4090

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

damiencarol
Copy link
Contributor

@damiencarol damiencarol commented Mar 19, 2021

This pull request fix few potential bugs on the size of title in findings for 3 parsers:

  • AWS Prowler
  • AWS Scout
  • Scoutsuite

Also this pull request add unit tests for scout2 parser which doesn't exists (!)

@valentijnscholten
Copy link
Member

Thanks, maybe we should implement something generic in models.py Finding.save()

@damiencarol
Copy link
Contributor Author

damiencarol commented Mar 21, 2021

@valentijnscholten you're right, it's better to do it in model. or after the call to get_findings(). Will make some modifications this way not in this PR I think as it will impact all parsers.

@madchap madchap merged commit b8cbab1 into DefectDojo:dev Mar 21, 2021
@damiencarol damiencarol deleted the fix_title_length branch March 21, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants