SARIF: support date of findings #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
Is the past around PASSED, lastobservedat and mitigated findings no longer needed? It looks like it was copied from another parser (aws?) |
madchap
approved these changes
Mar 23, 2021
|
@valentijnscholten yes you're right. bad code. didn't saw that because everything was good in UI and unit tests |
so it is correct that it is removed? or should it be put back? |
|
It's useless code. there is no mitigation in SARIF format. I tested 6 different sources. So we need to remove it. |
valentijnscholten
approved these changes
Mar 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work
ex:
django-DefectDojo/dojo/unittests/scans/sarif/appendix_k.sarif
Line 150 in ec47390