Clair parser: fixes TypeError: string indices must be integers #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding some unittests. On behalf of DB Systel GmbH
damiencarol
requested changes
Mar 25, 2021
|
@alles-klar what bug are you trying to fix? |
|
@damiencarol PR is ready from my perspective. Since #3827 the clair parser doesn't work at all and you get "TypeError: string indices must be integers". |
damiencarol
reviewed
Mar 25, 2021
damiencarol
approved these changes
Mar 25, 2021
|
@alles-klar good job! |
damiencarol
changed the title
valentijnscholten
approved these changes
Mar 25, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current parser is broken and throws Server Error 500 / "TypeError: string indices must be integers" when uploading a scan.
Also adding some unittests.
On behalf of DB Systel GmbH