Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python to 3.8 #4379

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Bump python to 3.8 #4379

merged 1 commit into from
Apr 28, 2021

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Apr 28, 2021

The kubernetes deployment in GHA keeps failing on Python 3.7, but works fine consitently on 3.8 so I propose we go with 3.8.
Fixes #4359

Python 3.8 also uses pip 21.1 which, by default, uses the new dependency resolver algorithm that caused a lot of issues in the past, but is now finally resolved as we can see in the tests in this PR and in #2978

@damiencarol
Copy link
Contributor

seems good :D

@damiencarol damiencarol added this to the 2.0.0 milestone Apr 28, 2021
@damiencarol damiencarol self-requested a review April 28, 2021 10:38
@valentijnscholten valentijnscholten changed the title WIP Bump python to 3.8 Bump python to 3.8 Apr 28, 2021
@valentijnscholten valentijnscholten marked this pull request as ready for review April 28, 2021 12:06
@madchap madchap merged commit d6a2b22 into DefectDojo:dev Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants