Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when running dedupe management command #4427

Merged
merged 3 commits into from
May 3, 2021

Conversation

madchap
Copy link
Collaborator

@madchap madchap commented May 2, 2021

Fixes #4426

@valentijnscholten
Copy link
Member

What I had as a bug a while ago is that I forgot to pass in the fields parameter somewhere, causing no fields to be updated. So I made it mandatory, but forgot dedupe.py it seems. I prefer to make the parameter mandatory, as having no fields is a non-default case and it would be good to force people to pass in fields=None if they don't want any fields to be updated.
i.e. change dedupe.py instead of utils.py :-)

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@madchap
Copy link
Collaborator Author

madchap commented May 3, 2021

That's what I thought first, but then I got lazy.

@valentijnscholten
Copy link
Member

I can fix it as it was my bug

@madchap
Copy link
Collaborator Author

madchap commented May 3, 2021

It's ok, you fix enough of mine :)

@damiencarol damiencarol merged commit f667f23 into dev May 3, 2021
@damiencarol damiencarol deleted the madchap-patch-5 branch May 3, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants