Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of the compute severity for Aqua JSON parser #4465

Merged
merged 11 commits into from
May 10, 2021
Merged

Change of the compute severity for Aqua JSON parser #4465

merged 11 commits into from
May 10, 2021

Conversation

SPoint42
Copy link
Contributor

@SPoint42 SPoint42 commented May 7, 2021 •
edited
Loading

Modification for the compute of Aqua scan JSON import as there is a aqua_severity we can use. See #4466

@SPoint42 SPoint42 changed the title Aqua severity Change of the compute for Aqua severity parser May 7, 2021
@SPoint42 SPoint42 changed the title Change of the compute for Aqua severity parser Change of the compute severity for Aqua severity parser May 7, 2021
@SPoint42 SPoint42 changed the title Change of the compute severity for Aqua severity parser Change of the compute severity for Aqua JSON parser May 7, 2021
@damiencarol damiencarol linked an issue May 7, 2021 that may be closed by this pull request
Aqua Parser did not use the good value for severity #4466
Closed
@valentijnscholten
Copy link
Member

Looks like the unit tests need an update to reflect the changes made:

uwsgi_1         | FAIL: test_aqua_parser_cvssv3_has_many_findings (dojo.unittests.tools.test_aqua_parser.TestAquaParser)
uwsgi_1         | ----------------------------------------------------------------------
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/app/dojo/unittests/tools/test_aqua_parser.py", line 59, in test_aqua_parser_cvssv3_has_many_findings
uwsgi_1         |     self.assertEqual(16, nb_cvssv3)
uwsgi_1         | AssertionError: 16 != 0
uwsgi_1         |

@SPoint42 SPoint42 marked this pull request as ready for review May 10, 2021 09:57
@SPoint42
Copy link
Contributor Author

SPoint42 commented May 10, 2021 •
edited
Loading

Looks like the unit tests need an update to reflect the changes made:

uwsgi_1         | FAIL: test_aqua_parser_cvssv3_has_many_findings (dojo.unittests.tools.test_aqua_parser.TestAquaParser)
uwsgi_1         | ----------------------------------------------------------------------
uwsgi_1         | Traceback (most recent call last):
uwsgi_1         |   File "/app/dojo/unittests/tools/test_aqua_parser.py", line 59, in test_aqua_parser_cvssv3_has_many_findings
uwsgi_1         |     self.assertEqual(16, nb_cvssv3)
uwsgi_1         | AssertionError: 16 != 0
uwsgi_1         |

✔️ Corrected

@valentijnscholten valentijnscholten merged commit 2539e52 into DefectDojo:dev May 10, 2021
@damiencarol damiencarol added this to the 2.0.0 milestone May 11, 2021
dsever pushed a commit to dsever/django-DefectDojo that referenced this pull request May 18, 2021
@SPoint42 @SpointLectra @dsever
Change of the compute severity for Aqua JSON parser (DefectDojo#4465)
b88a4e4 
* WIP: update the compute for severity

* add a new test file

* New compute for severity

* New compute for severity

* chore:flake8

* chore: fix cvss3 when having aqua_severity

* add unitests for aqua severity and fix some others

* add unitests for aqua severity and fix some others

* chore: one test for speed

Co-authored-by: Sebastien gioria <s.gioria@lectra.com>
madchap pushed a commit to madchap/django-DefectDojo that referenced this pull request May 30, 2023
@SPoint42 @SpointLectra @madchap
Change of the compute severity for Aqua JSON parser (DefectDojo#4465)
9633b48 
* WIP: update the compute for severity

* add a new test file

* New compute for severity

* New compute for severity

* chore:flake8

* chore: fix cvss3 when having aqua_severity

* add unitests for aqua severity and fix some others

* add unitests for aqua severity and fix some others

* chore: one test for speed

Co-authored-by: Sebastien gioria <s.gioria@lectra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiencarol damiencarol damiencarol approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Aqua Parser did not use the good value for severity
4 participants
@SPoint42 @valentijnscholten @damiencarol @SpointLectra