Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Generic parser] add JSON format #4484

Merged
merged 1 commit into from
May 23, 2021
Merged

[Generic parser] add JSON format #4484

merged 1 commit into from
May 23, 2021

Conversation

damiencarol
Copy link
Contributor

@damiencarol damiencarol commented May 11, 2021 •
edited
Loading

Add JSON format for the generic parser

  • support core attributes of findings

@damiencarol damiencarol marked this pull request as draft May 11, 2021 06:17
@valentijnscholten valentijnscholten mentioned this pull request May 13, 2021
Closed
mtesauro
mtesauro approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition to the generic CSV parser - thanks!

Approved

@damiencarol damiencarol linked an issue May 23, 2021 that may be closed by this pull request
Add Generic JSON importer #3798
Closed
@damiencarol damiencarol marked this pull request as ready for review May 23, 2021 13:37
@damiencarol
Copy link
Contributor Author

damiencarol commented May 23, 2021 •
edited
Loading

I'm splitting the PR in two: the part with the endpoints will come in another PR as I'm waiting the merge of #4473

@JohannesZahn

@valentijnscholten valentijnscholten merged commit 84f9b3d into DefectDojo:dev May 23, 2021
@damiencarol damiencarol deleted the add_generix_json branch May 24, 2021 22:52
adiffpirate pushed a commit to adiffpirate/django-DefectDojo that referenced this pull request May 30, 2021
@damiencarol @adiffpirate
[Generic parser] add JSON format (DefectDojo#4484)
a25a5d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

Assignees
No one assigned
Labels
easy-review Import Scans
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Generic JSON importer
3 participants
@damiencarol @mtesauro @valentijnscholten