Auto-redirect when only one Social Auth is defined #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't agree this should be the default behavior. Maybe optional via a config parameter, but not by default. |
|
@valentijnscholten, fixed in c5a25a9 |
valentijnscholten
approved these changes
May 15, 2021
|
Thanks, can you update the description as well? |
damiencarol
approved these changes
May 15, 2021
damiencarol
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
DD_SOCIAL_AUTH_SHOW_LOGIN_FORMis set toFalse(local login is not allowed) and there is exactly one Social Auth definition, the/loginpage automatically redirect to the Social login form.There is no reason to show only one Social button.