Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new parser - terrascan #4528

Merged
merged 6 commits into from
May 24, 2021
Merged

add new parser - terrascan #4528

merged 6 commits into from
May 24, 2021

Conversation

ansidorov
Copy link
Contributor

Terrascan is a static code analyzer for Infrastructure as Code.

It could be found at: https://github.com/accurics/terrascan

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if we need to set dedupe algorithm to HASH_CODE in settings? And if we need a hash code field config or can use the default? (Might be good to check the same for the previous parsers by you which we already merged)

@ansidorov
Copy link
Contributor Author

Can you check if we need to set dedupe algorithm to HASH_CODE in settings? And if we need a hash code field config or can use the default? (Might be good to check the same for the previous parsers by you which we already merged)

If I understand correctly, we need to use the default for terrascan parser.

@ansidorov
Copy link
Contributor Author

Can you check if we need to set dedupe algorithm to HASH_CODE in settings? And if we need a hash code field config or can use the default? (Might be good to check the same for the previous parsers by you which we already merged)

I thought again and adjusted the deduplication algorithm.

Co-authored-by: Damien Carol <damien.carol@gmail.com>
@damiencarol damiencarol merged commit 2588717 into DefectDojo:dev May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants