Stop deduplication across products #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a parser that has a dedupe algorithm set to `DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL_OR_HASH_CODE`, such as Veracode, deduplication would occur between products. This can be seen by importing the same report into two different products
devGregA
approved these changes
Jun 2, 2021
valentijnscholten
approved these changes
Jun 2, 2021
|
nice find, could be something to add to the unit tests as well, i can take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a parser that has a dedupe algorithm set to
DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL_OR_HASH_CODE, such as Veracode, deduplication would occur between products. This can be seen by importing the same report into two different products