[Endpoints] Change size of protocol + [Nexpose] consolidation of protocols

[kiblik]

No description provided.

[kiblik]

@damiencarol, 20 still doesn't cover this use-case. But it is really really edge case

[damiencarol]

Something is wrong with this parser and I'm glad that the new code on endpoints found it.
Take a look at the data:

                           <endpoint protocol="tcp" port="6101" status="open">
					<services>
						<service name="Backup Exec Agent Browser">
							<configuration>
								<config name="sslv3">false</config>
								<config name="tlsv1_0">false</config>
								<config name="tlsv1_1">false</config>
								<config name="tlsv1_2">false</config>
							</configuration>
							<tests>
							</tests>
						</service>
					</services>
				</endpoint>

The protocol value should be tcp and not some fake value backup-exec-agent-browser

[kiblik]

Well, yes and no. What about this case?

<endpoint protocol="tcp" port="80" status="open">
  <services>
    <service name="HTTP">

Or this

<endpoint protocol="tcp" port="22" status="open">
  <services>
    <service name="SSH">

Or you can compare it with this

<endpoint protocol="udp" port="53" status="open">
  <services>
      <service name="DNS">

I like this format: dns://192.168.1.1#tcp and dns://192.168.1.1#udp.

[kiblik]

We can use (in Nexpose parser) checking of existence in hyperlink._url.SCHEME_PORT_MAP like here and here
So, it is exist in hyperlink._url.SCHEME_PORT_MAP, use it, otherwise, use tcp or udp

[damiencarol]

Saw your commit, it's good.

[damiencarol]

Your comment are valid. Parsing protocol is tricky. I'm not surprised that the module hyperlink have internal mapping.

[valentijnscholten]

@kiblik can you rebase migration?

[kiblik]

@valentijnscholten, rebased and db_mig file moved

[kiblik]

tests failed but not because of my changes