Master into dev/2.1.0 2.2.0 dev #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanFl
approved these changes
Jul 29, 2021
helm/defectdojo/Chart.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v1 | |||
| appVersion: "2.1.0-dev" | |||
| appVersion: "2.2.0-dev" | |||
| description: A Helm chart for Kubernetes to install DefectDojo | |||
| name: defectdojo | |||
| version: 1.6.10 | |||
There was a problem hiding this comment.
I think we should merge that PR even though the version of the helm chart needs to be updated. We can create another PR with the updated chart version.
There was a problem hiding this comment.
I fear that would break the unit tests. Could be incorrect though. @valentijnscholten @madchap what are your thoughts?
There was a problem hiding this comment.
I usually bump it, so 1.6.11
valentijnscholten
suggested changes
Jul 30, 2021
helm/defectdojo/Chart.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v1 | |||
| appVersion: "2.1.0-dev" | |||
| appVersion: "2.2.0-dev" | |||
| description: A Helm chart for Kubernetes to install DefectDojo | |||
| name: defectdojo | |||
| version: 1.6.10 | |||
There was a problem hiding this comment.
I usually bump it, so 1.6.11
* Add release cadence to README * Update README.md * Update README.md Co-authored-by: Damien Carol <damien.carol@gmail.com> Co-authored-by: Damien Carol <damien.carol@gmail.com>
* AWS Prowler scanner enhancements Detected and fixed issues: - Inside the same scan findings from different regions were being marked as duplicates; - Missing useful information in finding description and fields; - dedup_key was not strong; - Deduplication was not working, so same scan would duplicate the number of findings. All those have been fixed. * Final cleanup * Fixing PEP8 * Noticed the parser was using an older version of Prowler as in the CSV export some fiels were removed and others were added. Working for PROWLER_VERSION=2.4.0-07042021 Some code cleanup as some unused fiels were there * Fixed the unit tests. CSV files were missing many fields. CSV fiels taken from CSV Export of PROWLER_VERSION=2.4.0-07042021
StefanFl
force-pushed
the
master-into-dev/2.1.0-2.2.0-dev
branch
from
222e047
to
68aff8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.