New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scan type list rely on Dynamic parser infra. #5084
Make scan type list rely on Dynamic parser infra. #5084
Conversation
Why is there such an urgency to remove the test_type table from the DB? |
@Maffooch Sorry the text was confusing. I will change the text of the PR. The goal is to have Test_type less "fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay that sounds better. I was under the impression the goal was to remove the entire table from the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me
@damiencarol I will approve this merge request if you do me one favour 😃: The list of parsers at the import page is not sorted. Please use |
I tried but it's not that simple. To do that we need to modify |
Not sure we talk about the same thing. I meant using django-DefectDojo/dojo/engagement/views.py Line 664 in b44af80
That does the trick. |
@StefanFl done. |
Simplify code around scan type lists and parser loading/validating making some serializer/forms don't rely on DB but on code directly.