Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack notification: get user by email instead of searching all users #5091

Merged
merged 1 commit into from Jan 2, 2022
Merged

Slack notification: get user by email instead of searching all users #5091

merged 1 commit into from Jan 2, 2022

Conversation

valentijnscholten
Copy link
Member

fixes #4937

@valentijnscholten valentijnscholten changed the base branch from master to dev September 13, 2021 16:33
@valentijnscholten valentijnscholten mentioned this pull request Sep 13, 2021
Closed
4 tasks
Maffooch
Maffooch previously approved these changes Sep 13, 2021
View reviewed changes
@valentijnscholten
Copy link
Member Author

I have no idea if this works as I just copied the suggestion into a pr. Anyone able to test it?

@Maffooch
Copy link
Contributor

Oh I assumed it was tested before being made a PR. Maybe convert it to a draft so it does not accidentally get merged?

@valentijnscholten
Copy link
Member Author

Of you dismiss your review is pretty clear I think with the comments and all.

@Maffooch Maffooch dismissed their stale review September 13, 2021 18:26

PR has not been tested

@whitespots
Copy link

image

@whitespots
Copy link

Each time new alert :))

So, on the other side there are such scopes:
image

@whitespots
Copy link

Actually, even after setting the slack email in user settings we can see just more issues in logs :)
image

@valentijnscholten
Copy link
Member Author

valentijnscholten commented Sep 13, 2021 •
edited

thanks for testing, but your error seems completely unrelated to the one from the original reporter. can you open your own issue and put your details / screenshots in there?

@valentijnscholten valentijnscholten added this to the 2.4.0 milestone Oct 28, 2021
@Maffooch
Copy link
Contributor

Maffooch commented Nov 1, 2021

@valentijnscholten is the solution you have ready to go? I didn't think it was in working order yet

@valentijnscholten
Copy link
Member Author

@hackthesoul Can you test this so we can include it in the release today?

@valentijnscholten valentijnscholten modified the milestones: 2.4.0, 2.5.0 Nov 2, 2021
@valentijnscholten
Copy link
Member Author

No more time to test this and not many reports, moving to 2.5.0.

@StefanFl
Copy link
Member

StefanFl commented Dec 6, 2021

@valentijnscholten What is your recommendation how to proceed with this PR, if we cannot test it?

@valentijnscholten valentijnscholten modified the milestones: 2.5.0, 2.6.0 Dec 7, 2021
@devGregA devGregA self-requested a review December 28, 2021 18:04
mtesauro
mtesauro approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten valentijnscholten merged commit f8b91fd into DefectDojo:dev Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@devGregA devGregA devGregA approved these changes

@Maffooch Maffooch Maffooch left review comments

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

slack notification bug to find user profile
6 participants
@valentijnscholten @Maffooch @whitespots @StefanFl @mtesauro @devGregA