First step to internationalization

[shipko]

Hi guys!

I want to add localization in project.
Why it need?
This will make it possible to translate the interface on other language. If company needs interface on other language - it can generate locale file.
On first step I decided prepare base.html file. If my pull request will be interesting for you, I continue work

[damiencarol]

@shipko Don't you need a localization file to match the strings to localize?

[devGregA]

Hi @shipko nice to meet you! I've always wanted to pursue multilingual support. Wouldn't it be better to start with the models rather than the templates?

[shipko]

@damiencarol on first step it's not require. Django will use words wrapped in translatization function.

If somebody wants to use other language can execute django-admin makemessages -l , replace LANGUAGE_CODE in settings.dist.py and translate language file

[shipko]

@devGregA of course. This not last commit. After that I will start edit models.py

[shipko]

@devGregA wrapped models.py to translatization form.

[damiencarol]

wow. this will be a big DB migration. (every model that have some description)

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[shipko]

That's all @devGregA @damiencarol
I edited base.html and models.py
For the beginning I think that completely done first step for i18n

Also i notice that no required migration, because we changed 'verbose_name' and 'help_text' parameters.

Please approve my PR or write that I need to fix. Because I don't want to resolve merge conflicts in soon

[damiencarol]

@shipko could you add some languages files? I want to test this PR (adding a new language, changing the data, etc..)

[shipko]

@damiencarol of course!
This is test branch where I added some required files for testing.
This files changed only some elements in left bar menu. Another elements should be translated in /dojo/locale/ru/LC_MESSAGES/django.po file.

I want to notice, that this files from test branch will not be merged in dev branch.

[shipko]

@damiencarol you have news?

[damiencarol]

I'm still testing. I need to catch-up with the team as it will impact the whole UI.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[shipko]

@damiencarol I agree with @valentijnscholten and want to use _() construction. Because it's ~95% cases. For another cases we will be use another functions (ngettext(), gettext_lazy(), ...)

If you're ok about this, I won't change anything

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[damiencarol]

@shipko ok.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[shipko]

@damiencarol @devGregA @valentijnscholten please leave feedback about this pr. I constantly resolve merge conflicts. It's boring

[valentijnscholten]

I understand. I have no experience with i18n, especially not in Django. I guess if this PR follows the docs it should be OK.
One thing I am wondering is how it would work if a string has variables/parameters/interpolation.
Something like the example in the docs:

But strangely enough I can't find how that would actually work in the .po file.

I've pinged the rest of the team to look at the PR, but I'm good with it.

[devGregA]

@shipko looking at this now

[devGregA]

@Maffooch would you also please review?

[damiencarol]

It's good enough for me as a first step. I made a couple of tests by adding a new language. I will accept it before the end of the week if everything is ok.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Maffooch]

I've done a quick performance test with this to be sure making translations via the templates would not be too impacting. Django's template loader can be super slow with certain operations.

I found that there really is no discernible difference, and that this is the standard way of doing django internalization. Approving for now

[shipko]

@Maffooch thanks!

@damiencarol @valentijnscholten @devGregA what about you?