WIP: Notification profile #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
New Migration
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -69,6 +72,11 @@ <h3> {% if scope == 'system' %}System{% else %}Personal{% endif %} Notification | |||
| <td class="centered"> | |||
| <input type="checkbox" name="{{ field.name }}" {% if c in field.value %}checked{% endif %} value="{{ c }}"/> | |||
| </td> | |||
| {% elif scope == 'template' and c in enabled_notifications and c != 'msteams' %} | |||
| <td class="centered"> | |||
| <input type="checkbox" name="{{ field.name }}" {% if c in field.value %}checked{% endif %} value="{{ c }}"/> | |||
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
dsever
force-pushed
the
notification-profiles
branch
from
fd234ba
to
d153b46
Compare
StefanFl
suggested changes
Jan 29, 2022
github-actions
bot
added
apiv2
docker
docs
parser
settings_changes
dsever
force-pushed
the
notification-profiles
branch
from
e0e6a61
to
76b0803
Compare
github-actions
bot
removed
settings_changes
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
dsever
force-pushed
the
notification-profiles
branch
from
657c5f2
to
a5cd230
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
@dsever Is this PR still a draft or ready for review? |
|
@StefanFl I think it is ready. |
Maffooch
approved these changes
Mar 9, 2022
|
I will have a look at it as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.2022-01-27.22.09.24.mp4
It implements single template for notifications that is applied automatically during the user creation (GUI only)
@StefanFl can you please take a look...do you have better idea how to do it?
TODO: