-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding group enhancements #6053
Conversation
dsever
commented
Mar 22, 2022
- This PR shows group real names names instead of Y and N.
- removes 'Experimental notification'
- and moves configuration (enable/disable) from config file to DB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR should either migrate the existing setting into the DB for existing installs and/or add something to the upgrade notes. Ideally if users have disabled finding groups, it should remain disabled after upgrading to the version that includes this PR.
This is true, will try to add it |
@StefanFl @valentijnscholten Changes have been implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Experience has shown it's better to separate schema migrations and data migrations. Data migrations sometimes fail and having them in a separate migration allows for easy retry without having to comment out any schema parts that were successful. Could you split them up?
@valentijnscholten, Done |