Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view tool product error #6113

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix view tool product error #6113

merged 1 commit into from
Apr 4, 2022

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Apr 3, 2022 •
edited

fixes #6111

'view_tool_product' not found when I added a tool or clicked on view tools on product dashboard settings.

@valentijnscholten valentijnscholten changed the base branch from master to dev April 3, 2022 16:57
@github-actions github-actions bot added the ui label Apr 3, 2022
@valentijnscholten
Copy link
Member Author

Not sure what happened with this view, and if there is a testcase missing, but removing this commented out code resolves the error from #6111 @StefanFl @kiblik

StefanFl
StefanFl approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@StefanFl StefanFl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is really weird. I removed the view_tool_product a while ago, because there was no url attached to it. But why can a commented piece of code make a problem. Anyway, great you found and fixed it.

@StefanFl StefanFl added this to the 2.9.0 milestone Apr 3, 2022
@valentijnscholten
Copy link
Member Author

It's commented in html, the Django template still is trying to render it.

mtesauro
mtesauro approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit bbeff1b into DefectDojo:dev Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanFl StefanFl StefanFl approved these changes

@mtesauro mtesauro mtesauro approved these changes

Assignees
No one assigned
Labels
bugfix ui
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

'view_tool_product' not found when I added a tool or clicked on view tools on product dashboard settings.
3 participants
@valentijnscholten @StefanFl @mtesauro