Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parser and importer for Vulners.com reports API #6692

Merged
merged 16 commits into from
Dec 4, 2022
Merged

Add parser and importer for Vulners.com reports API #6692

merged 16 commits into from
Dec 4, 2022

Conversation

vankyver
Copy link
Contributor

Adding vulners.com reports parser.

@github-actions github-actions bot added parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests labels Aug 11, 2022
@vankyver vankyver changed the title Vulners Add parser and importer for Vulners.com reports API Aug 11, 2022
damiencarol
damiencarol requested changes Aug 11, 2022
View reviewed changes
unittests/tools/test_vulners_parser.py Outdated Show resolved Hide resolved
dojo/tools/vulners/parser.py Outdated Show resolved Hide resolved
dojo/tools/vulners/parser.py Outdated Show resolved Hide resolved
dojo/tools/vulners/api_client.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vankyver
Copy link
Contributor Author

@damiencarol Looks like all required fixes done. Can we finalise review?

@damiencarol
Copy link
Contributor

@vankyver :

Made a review of the official SDK and it support proxies.

https://github.com/vulnersCom/api/blob/f56dab4ffcdb400da58b680d7feb89cae3550984/vulners/api.py#L97-L105

image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vankyver
Copy link
Contributor Author

vankyver commented Sep 8, 2022

@vankyver :

Made a review of the official SDK and it support proxies.

https://github.com/vulnersCom/api/blob/f56dab4ffcdb400da58b680d7feb89cae3550984/vulners/api.py#L97-L105

image

@damiencarol I've added fixes with including Vulners SDK

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

damiencarol
damiencarol requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@damiencarol damiencarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better but the current PR doesn't support proxies. is it still one of your goal?

dojo/tools/vulners/api_client.py Show resolved Hide resolved
dojo/settings/settings.dist.py Show resolved Hide resolved
dojo/tools/vulners/api_client.py Outdated Show resolved Hide resolved
@Maffooch Maffooch modified the milestones: 2.16.0, 2.17.0 Oct 26, 2022
@Maffooch
Copy link
Contributor

@vankyver please see feedback from Damien

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

manuel-sommer
manuel-sommer suggested changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@manuel-sommer manuel-sommer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@manuel-sommer
Copy link
Contributor

As @vankyver did not reply over a month, would it be an option to make another PR including these changes plus the requested changes from @damiencarol and close this PR?

@Maffooch
Copy link
Contributor

@manuel-sommer that is cool with me!

@damiencarol
Copy link
Contributor

@manuel-sommer , @Maffooch : if @vankyver is ok, I can "finish" the PR.

@Maffooch
Copy link
Contributor

@damiencarol either way works! This PR has two approvals so you could change and merge at your timeline

@vankyver
Copy link
Contributor Author

Hi, sorry, hard month, going to come back with changes asap.

@github-actions github-actions bot added the docs label Nov 24, 2022
manuel-sommer
manuel-sommer approved these changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@manuel-sommer manuel-sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding the parser to the documentation

@mtesauro
Copy link
Contributor

@damiencarol Was looking at this and was about to merge since it has 2 approvals but couldn't tell from the thread if there was work you still wanted to do.

So, I'll wait to give you a chance to chime it or address the changes you requested. 👍

@vankyver
Copy link
Contributor Author

@damiencarol From my point of view, everything is ready, so I hope that now we can complete the pull request.

@damiencarol damiencarol merged commit d4a8499 into DefectDojo:dev Dec 4, 2022
@damiencarol
Copy link
Contributor

Great work @vankyver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiencarol damiencarol damiencarol approved these changes

@devGregA devGregA devGregA approved these changes

@Maffooch Maffooch Maffooch approved these changes

@manuel-sommer manuel-sommer manuel-sommer approved these changes

Assignees

@Maffooch Maffooch

Labels
docs parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests Waiting on response
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vankyver @damiencarol @mtesauro @devGregA @Maffooch @manuel-sommer