Add Status of Findings when Close Finding

[italvi]

This is a try to resolve the issue discussed in #7059

Result:

[italvi]

@alles-klar as far as I know you are an expert to the k8 deployment: Do you know why it fails?
"Error: looks like "https://charts.bitnami.com/bitnami" is not a valid chart repository or cannot be reached: Get "https://charts.bitnami.com/bitnami/index.yaml": dial tcp: lookup charts.bitnami.com on 127.0.0.53:53: no such host"

[mtesauro]

I re-ran the failed ones and it seems to be working now.

[italvi]

@Maffooch you are right with the .get. Was a bit lazy from my side to do it in one file but not another. I implemented your suggestion and added a missing apostrophe.

[italvi]

I have 2 improvements that I would like to add in the future:

1. For the duplicates field there should be the possiblity to choose from findings which is the "original"
2. Remove the possibility to edit the status in the EditForm, s.t. nobody can just change the status without adding a note.

What do you think? Would this be also good PR?

[Maffooch]

For the duplicates field there should be the possiblity to choose from findings which is the "original"

This seems sensical to me when manually setting the flag.

Remove the possibility to edit the status in the EditForm, s.t. nobody can just change the status without adding a note.

I think this would be a little annoying tbh. Especially for smaller teams or folks just getting to know dojo. I think it would be best to leave that to the users

[italvi]

Remove the possibility to edit the status in the EditForm, s.t. nobody can just change the status without adding a note.

I think this would be a little annoying tbh. Especially for smaller teams or folks just getting to know dojo. I think it would be best to leave that to the users

@Maffooch could you explain me https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/finding/views.py#L744 then? It seems to me that somebody had the inital thought of checking whether the finding includes any notes? If so, then the contributor made a mistake with closing_disabled!=0, which should be closing_disabled==0 as note_type_activation will be 0 when there are no notes and therefore closing_disabled will remain 0

[Maffooch]

Looks like something to do with note types from this #1539
From just a brief skim of the PR description, it looks like if you have a specific note type configured, it requires that a note of that type be present in the finding before it is actually closed. I like this approach

[italvi]

@mtesauro could you please review the PR too or is something missing?

[mtesauro]

@italvi LGTM - approving and merging

[mtesauro]

Approve