Fix appscreener parser #7077
Merged
Fix appscreener parser #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error, when trying to parse appscreener report.
[05/Nov/2022 01:41:15] ERROR [dojo.engagement.views:683] invalid literal for int() with base 10: ''
Traceback (most recent call last):
File "/app/./dojo/engagement/views.py", line 668, in import_scan_results
test, finding_count, closed_finding_count, _ = importer.import_scan(scan, scan_type, engagement, user, environment, active=active, verified=verified, tags=tags,
File "/app/./dojo/importers/importer/importer.py", line 298, in import_scan
parsed_findings = parser.get_findings(scan, test)
File "/app/./dojo/tools/solar_appscreener/parser.py", line 50, in get_findings
finding.line = int(finding.line)
ValueError: invalid literal for int() with base 10: ''
Because first line transfer to string after split. This fix should resolve it. I checked - all ok.
|
@ncrl fixed some flake8 errors and improved some stuffs |
manuel-sommer
suggested changes
Nov 5, 2022
Done! |
ncrl
commented
Nov 6, 2022
| @@ -47,7 +47,7 @@ def get_findings(self, filename, test): | |||
| if finding.line: | |||
| if not finding.line.isdigit(): | |||
| finding.line = finding.line.split("-")[0] | |||
| finding.line = int(finding.line) | |||
| finding.line = int(finding.line) | |||
There was a problem hiding this comment.
I think the error is still there, because after split if '-' will be on input string got on output. @damiencarol
Maffooch
approved these changes
Nov 9, 2022
manuel-sommer
approved these changes
Nov 10, 2022
|
@ncrl you have to request another approving review, e.g. from @damiencarol |
Maffooch
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Update parser.py
Error, when trying to parse appscreener report.
[05/Nov/2022 01:41:15] ERROR [dojo.engagement.views:683] invalid literal for int() with base 10: ''
Traceback (most recent call last):
File "/app/./dojo/engagement/views.py", line 668, in import_scan_results
test, finding_count, closed_finding_count, _ = importer.import_scan(scan, scan_type, engagement, user, environment, active=active, verified=verified, tags=tags,
File "/app/./dojo/importers/importer/importer.py", line 298, in import_scan
parsed_findings = parser.get_findings(scan, test)
File "/app/./dojo/tools/solar_appscreener/parser.py", line 50, in get_findings
finding.line = int(finding.line)
ValueError: invalid literal for int() with base 10: ''
Because first line transfer to string after split. This fix should resolve it. I checked - all ok.
* Update parser.py
* Update parser.py
* Update parser.py
* Update parser.py
* Fix error: ValueError: invalid literal for int() with base 10: ''
* Update parser.py
Flake8 fix
Co-authored-by: Damien Carol <damien.carol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error, when trying to parse appscreener report.
[05/Nov/2022 01:41:15] ERROR [dojo.engagement.views:683] invalid literal for int() with base 10: '' Traceback (most recent call last):
File "/app/./dojo/engagement/views.py", line 668, in import_scan_results
test, finding_count, closed_finding_count, _ = importer.import_scan(scan, scan_type, engagement, user, environment, active=active, verified=verified, tags=tags,
File "/app/./dojo/importers/importer/importer.py", line 298, in import_scan
parsed_findings = parser.get_findings(scan, test)
File "/app/./dojo/tools/solar_appscreener/parser.py", line 50, in get_findings
finding.line = int(finding.line)
ValueError: invalid literal for int() with base 10: ''
Because first line transfer to string after split. This fix should resolve it. I checked - all ok.