Adjusted Rusty Hog deduplication to be less flaky #7164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2022 16:20
…fter non-mitigating changes more robust
github-actions
bot
added
parser
settings_changes
Maffooch
approved these changes
Nov 18, 2022
devGregA
approved these changes
Nov 18, 2022
damiencarol
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the same finding (e.g. a secret string in line 3) will not be deduplicated in case its line shifts (e.g. new lines included in between), but instead be found as a new finding, thought the core issue was not resolved.
This change adjusts the hashcode calculation to include the file path + actual occurrence of the secret string.