-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the design of the custom html report findings #7236
Improved the design of the custom html report findings #7236
Conversation
- Made the finding main header smaller to include the counter and the DefectDojo ID number - Included the score in the severity - Added the CVE if it exists with the relevant web link - Location: Added the Service and fixed the issue with the file path width
Took a closer look and some things jumped out at me. Working on a full review
Doing a few more tests @Maffooch locally. Will let you know if all is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone through all of your comments @Maffooch and resolved them
Would be great if you could reconsider @Maffooch and add this PR in the 2.17.0 milestone together with the other PR I have for the JFrog XRay parser. Need to produce reports before the end of the year for the client. |
Most revisions look good! I am still weary about the title though. Do you have a screenshot? |
Hi @Maffooch, for this PR the importance is on having the necessary data on the report. I have reverted the design of the title and the id to the old style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make sure it gets into this release
I hope you like the changes, it produces smaller in size reports and includes additional and important information related to a finding.