Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the design of the custom html report findings #7236

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

madeoninfo
Copy link
Contributor

  • Made the finding main header smaller to include the counter and the DefectDojo ID number
  • Included the score in the severity
  • Added the CVE if it exists with the relevant web link
  • Location: Added the Service and fixed the issue with the file path width

image

I hope you like the changes, it produces smaller in size reports and includes additional and important information related to a finding.

- Made the finding main header smaller to include the counter and the DefectDojo ID number
- Included the score in the severity
- Added the CVE if it exists with the relevant web link
- Location: Added the Service and fixed the issue with the file path width
@github-actions github-actions bot added the ui label Dec 5, 2022
Maffooch
Maffooch previously approved these changes Dec 5, 2022
@Maffooch Maffooch added this to the 2.17.0 milestone Dec 5, 2022
@Maffooch Maffooch dismissed their stale review December 5, 2022 18:35

Took a closer look and some things jumped out at me. Working on a full review

@Maffooch Maffooch modified the milestones: 2.17.0, 2.18.0 Dec 5, 2022
@madeoninfo
Copy link
Contributor Author

Doing a few more tests @Maffooch locally. Will let you know if all is ok

Copy link
Contributor Author

@madeoninfo madeoninfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone through all of your comments @Maffooch and resolved them

@madeoninfo
Copy link
Contributor Author

Would be great if you could reconsider @Maffooch and add this PR in the 2.17.0 milestone together with the other PR I have for the JFrog XRay parser. Need to produce reports before the end of the year for the client.

@Maffooch
Copy link
Contributor

Maffooch commented Dec 5, 2022

Most revisions look good! I am still weary about the title though. Do you have a screenshot?

@madeoninfo
Copy link
Contributor Author

madeoninfo commented Dec 5, 2022

Most revisions look good! I am still weary about the title though. Do you have a screenshot?

image

In the blue header the text looks bloated if it has long text, for example:

image

@Maffooch
Copy link
Contributor

Maffooch commented Dec 5, 2022

Hmm.. This could just be personal preference, but I think it is much more intuitive to have the title as the header, and then the dojo ID as a table entry (similar to the way it was before)

@mtesauro @devGregA thoughts?

@madeoninfo
Copy link
Contributor Author

madeoninfo commented Dec 6, 2022

Hi @Maffooch, for this PR the importance is on having the necessary data on the report. I have reverted the design of the title and the id to the old style.

Screenshot 2022-12-06 084409

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make sure it gets into this release

@Maffooch Maffooch modified the milestones: 2.18.0, 2.17.0 Dec 6, 2022
@Maffooch Maffooch merged commit 19466dc into DefectDojo:dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants