In the re-importer, if the new finding is mitigated then make sure th… #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
force-pushed
the
coheigea/endpoints_mitigated
branch
from
8d7d666
to
e2db1c7
Compare
|
@coheigea I think this would be a good candidate for the |
…e old finding's endpoints are all mitigated
coheigea
force-pushed
the
coheigea/endpoints_mitigated
branch
from
e2db1c7
to
dee3ec2
Compare
|
@Maffooch Thanks, I've rebased now against bugfix |
|
@Maffooch I rebased so that only my commit was in the PR against bugfix, but the lint helm chart failed. Did I do the right thing? Maybe the update version PRs should be merged to bugfix first so that PRs against the branch can pass? |
|
Hmm. I need to add an exclusion to the helm chart test so that it does not run against this branch (similar to the dev branch) You're the first one on this branch, so I'll need to work all these bugs out. Will start on this in a few hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e old finding's endpoints are all mitigated
If you re-import a finding that was mitigated upstream, then the endpoints will stay active on the original finding. If de-duplication is enabled you see a single mitigated finding with an active endpoint.