Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github parser] Parse dependabot alert number and add link in description #8050

Merged
merged 7 commits into from
May 4, 2023

Conversation

Gby56
Copy link
Contributor

@Gby56 Gby56 commented May 3, 2023

It's currently quite unusable to view dependabot alerts because they don't give a direct link into the Github platform, to maybe triage things there, get more details... view the PR attached etc...

Funny thing is, Github doesn't return a direct link to the alert, so you must either return the repo URL, or at least the full name with the org/owner, and build from there.

Another thing that I can't fix unfortunately: directly linking to the file in Github is hard, because yet again, Github's API isn't telling you the branch where the issue was detected. Dependabot opens PRs properly though, so maybe you could introspect the PR it has opened and find out the target branch... if someone reads this and wants to bother

@github-actions github-actions bot added the parser label May 3, 2023
@github-actions github-actions bot added the docs label May 3, 2023
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@cneill cneill merged commit 497cff8 into DefectDojo:dev May 4, 2023
113 checks passed
@Gby56 Gby56 deleted the patch-1 branch May 5, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants