Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Tag Inheritance #8089

Merged
merged 8 commits into from
May 13, 2023
Merged

Implement Tag Inheritance #8089

merged 8 commits into from
May 13, 2023

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented May 10, 2023 •
edited

Functionality to add tags of a Product to all child objects (Engagement, Endpoint, Test, Finding) automatically. This is intended to be a set a forget flag.

  • Implementation
    • Feature flag in system settings (global) and product (local)
    • Signal infra to allow to inherited tags to be attached to new and existing objects on save
    • Auto propagation to all child objects when Product tags are added
  • Unit Tests
  • Documentation
    • Tags as a whole (somehow this has not happened before)
    • Inherited Tags

@github-actions github-actions bot added apiv2 New Migration Adding a new migration file. Take care when merging. unittests labels May 11, 2023
@Maffooch Maffooch marked this pull request as ready for review May 11, 2023 19:36
@github-actions github-actions bot added the docs label May 11, 2023
mtesauro
mtesauro approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

grendel513
grendel513 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@grendel513 grendel513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

cneill
cneill reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, otherwise LGTM

docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
docs/content/en/usage/features.md Outdated Show resolved Hide resolved
dojo/product/helpers.py Outdated Show resolved Hide resolved
@Maffooch Maffooch merged commit deb8357 into DefectDojo:dev May 13, 2023
113 checks passed
@Maffooch Maffooch deleted the sc-460 branch May 24, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grendel513 grendel513 grendel513 approved these changes

@cneill cneill cneill approved these changes

@mtesauro mtesauro mtesauro approved these changes

@blakeaowens blakeaowens blakeaowens approved these changes

Assignees
No one assigned
Labels
apiv2 docs New Migration Adding a new migration file. Take care when merging. unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Maffooch @grendel513 @cneill @mtesauro @blakeaowens