Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify push to jira logic for finding/groups review/open/close #8162

Merged
merged 2 commits into from
May 26, 2023

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented May 25, 2023

Sometimes when working with the jira integration, there are instances of a finding being pushed to jira when modifying the status of a finding via the edit page, but not when using the open/close/review buttons. This is confusing and creates disparity.

Here is what this PR does

  • Update single/grouped findings in Jira when a single finding is closed/open
  • Update single/grouped findings in Jira when a single finding has a requested review, cleared review, or actually reviewed
  • Correct statuses of findings under review to be Active instead of Inactive. This makes more sense as the decision for whether the finding is valid/mitigated is still up for debate and should not be marked as inactive until confirmed via review
  • Correct statuses of findings that have been reviewed when "not fixed" was selected. Previously, the finding would not be updated and would stay in an inactive state. This is crazy. The behavior now is the finding will be active and verified since it is confirmed the finding was not actually fixed and should this fact has been verified.
  • Correct statuses of findings that have been reviewed when "Closed" was selected. Previously, the finding would not be marked as verified, but that is the whole point of the review. So now the finding will be marked as inactive, mitigated, and verified.
  • Express Jira instance creation would not save the "automatically sync findings" flag. It does now
    [sc-1040]

Copy link
Contributor Author

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until @37b has a chance to review

Copy link
Contributor

@37b 37b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@Maffooch Maffooch merged commit e2f3363 into DefectDojo:bugfix May 26, 2023
113 checks passed
@Maffooch Maffooch deleted the jira_auto branch June 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants