New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helper.py to fix #8785 #8786
Conversation
this will fix DefectDojo#8785
added extra check to verify if assignee was actually set correctly after ticket creation
Flake8 is very unhappy :/ please take a look |
For what I could see, none of the warnings come from the changes I made. |
hi @Maffooch , just checking if you had the chance to read my last response. thanks |
Hi @devsecopsale apologies, I missed your response. It does look like none of the errors flake8 are reporting are a result of changes you made. Unfortunately, I am unable to merge the PR until all checks are passing |
replaced '==' by 'is' when comparing types
python: can't open file '/home/runner/work/django-DefectDojo/django-DefectDojo/.github/scripts/git_protect.py': [Errno 2] No such file or directory |
hi @Maffooch , any idea of what this check is about? can this be rerun? |
@devsecopsale About that test - see here: #8974 It allows us to signal contributors that they are touching files that we may be actively working on updating/doing a re-write. I don't have time right now to review this PR but that test isn't something you can "pass" short of removing the file(s) from the PR which probably isn't possible for this one. Think of this as a heads-up that we're going to look a bit more closely at this PR vs a parser PR for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@dougmorato , @Juu: I just need 2 more approvals to merge. Thank you |
this will fix #8785
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
this will fix #8785 , by adding the jira.project default_assignee (when defined) to the issue creation api call instead of adding a second step to do it.
Test results
this was tested in 2.23.2 and allowed to create issues in a Jira project where no 'unassigned' or 'automatic' assignee was allowed.
Documentation
Checklist
This checklist is for your information.
dev
.dev
.bugfix
branch.Extra information
Please clear everything below when submitting your pull request, it's here purely for your information.
Moderators: Labels currently accepted for PRs:
Contributors: Git Tips
Rebase on dev branch
If the dev branch has changed since you started working on it, please rebase your work after the current dev.
On your working branch
mybranch
:In case of conflict:
When everything's fine on your local branch, force push to your
myOrigin
remote:To cancel everything:
Squashing commits
pick
byfixup
on the commits you want squashed outpick
byreword
on the first commit if you want to change the commit messageForce push to your
myOrigin
remote: