Add support for more GIT SCMs in finding view for the finding URL #9710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🔴 Risk threshold exceeded. Adding a reviewer if one is configured in notification list: @mtesauro @grendel513 Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
Maffooch
approved these changes
Mar 25, 2024
blakeaowens
approved these changes
Mar 27, 2024
hblankenship
approved these changes
Apr 30, 2024
dogboat
pushed a commit
to dogboat/django-DefectDojo
that referenced
this pull request
May 6, 2024
…fectDojo#9710) * Add support for more GIT SCMs * fix flake8 issue * docs: added other supported SCM to the documentation --------- Co-authored-by: Eugeniu David <eugeniu.david@mic-cust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked the finding URL generation method to cover more GIT SCMs (github, gitlab, gitea, codeberg, bitbucket) by default. Also unified the bitbucket and github link generation methods into 1.
Test results
Added two new tests to test the new functionality, make sure that the function generates the correct URL for gitea.