Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff Linter: Resolve deprecation notice #9729

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

Maffooch
Copy link
Contributor

There are some warnings on the ruff linter action related to the deprecated default check action. The action must be explicitly set now

[sc-4736]

There are some warnings on the ruff linter action related to the deprecated default `check` action. The action must be explicitly set now

[sc-4736]
Copy link

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@Maffooch
Copy link
Contributor Author

Couple things to note to avoid confusion as I got tripped up by this during testing:

  • Deprecation warning is still present in in the Ruff Linter / ruff-linting (pull_request_target) action since that action is run from the branch this PR is being merged into (in this case it is bugfix)
  • The Ruff Linter / ruff-linting (push) action is correct now as that action is running from my Maffooch-patch-6 branch

The warning will be resolved in all branches on the next release as the workflow file will be updated on all three branches at that time

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@grendel513 grendel513 merged commit d81d5d7 into bugfix Mar 18, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants