🎇 refactor sonarqube and add JSON parsing for api export #9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
manuel-sommer
commented
Mar 13, 2024
•
manuel-sommer
commented
- see issue Advance SonarQube file import to parse JSON output directly from the API #9732
- also support multiple files from rest api at once with zip file Advance SonarQube file import to parse JSON output directly from the API #9732
- refactoring sonarqube in order to make debugging easier
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
mtesauro
reviewed
Mar 14, 2024
|
@manuel-sommer Thanks for the changes - probably shouldn't have tried to review this when I had so little time since I mis-read a couple of things in my hurry. |
Maffooch
approved these changes
Mar 25, 2024
blakeaowens
approved these changes
Mar 27, 2024
|
Hi @mtesauro, could we merge this before the next release? I would appreciate it as I would need it. Only one review is pending. |
|
@cneill could you take a look here please? |
cneill
requested changes
Mar 30, 2024
|
Hi @cneill, I changed the code according to your review, but I have no clue why ruff fails now. The references are right, but not detected from ruff. |
cneill
reviewed
Mar 30, 2024
manuel-sommer
force-pushed
the
rework_sonarqube
branch
from
8ef7374
to
b319e15
Compare
|
Done, thank you for your input and review @cneill. 😄 |
cneill
approved these changes
Apr 1, 2024
manuel-sommer
added a commit
to manuel-sommer/django-DefectDojo
that referenced
this pull request
Apr 3, 2024
…9734) * 🎇 refactor sonarqube and add JSON parsing for api export * 🚧 start with api json * continue work * update * update * fix * 🎉 also advance to support multiple files at once via zip due to pagination * advance unittests * advance documentation * update documentation * update documentation * add tags to distinguish between findings * :pencile: docs * add cve * add cwe * add cvssscore * 💄 * 🎉 add components * add ghsa * 🐛 fix for empty zip file * empty json file * fix documentation * 🐛 fix for different message structure * parse hotspots * fix according to review * ruff
hblankenship
pushed a commit
to hblankenship/django-DefectDojo
that referenced
this pull request
Apr 26, 2024
…9734) * 🎇 refactor sonarqube and add JSON parsing for api export * 🚧 start with api json * continue work * update * update * fix * 🎉 also advance to support multiple files at once via zip due to pagination * advance unittests * advance documentation * update documentation * update documentation * add tags to distinguish between findings * :pencile: docs * add cve * add cwe * add cvssscore * 💄 * 🎉 add components * add ghsa * 🐛 fix for empty zip file * empty json file * fix documentation * 🐛 fix for different message structure * parse hotspots * fix according to review * ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.