Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Solve E402 #9748

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Ruff: Solve E402 #9748

merged 3 commits into from
Mar 25, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 16, 2024

Remove E402 from lint.ignore and fix the findings

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR parser labels Mar 16, 2024
Copy link

dryrunsecurity bot commented Mar 16, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@kiblik kiblik marked this pull request as draft March 16, 2024 23:26
@kiblik kiblik marked this pull request as ready for review March 17, 2024 00:52
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kiblik kiblik force-pushed the ruff_E402 branch 2 times, most recently from 2f0ebbc to 33ae2bb Compare March 19, 2024 09:06
@kiblik kiblik closed this Mar 19, 2024
@kiblik kiblik reopened this Mar 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik closed this Mar 25, 2024
@kiblik kiblik reopened this Mar 25, 2024
@Maffooch Maffooch merged commit 44b4941 into DefectDojo:bugfix Mar 25, 2024
121 checks passed
manuel-sommer pushed a commit to manuel-sommer/django-DefectDojo that referenced this pull request Mar 27, 2024
* Ruff: solve E402

* Apply on flake8

---------

Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com>
@kiblik kiblik deleted the ruff_E402 branch April 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants