Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff: add isort #9754

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Ruff: add isort #9754

merged 2 commits into from
Apr 30, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 16, 2024

Add support for https://pypi.org/project/isort/ in Ruff

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 unittests integration_tests ui parser labels Mar 16, 2024
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 16, 2024 •
edited

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
AppSec Analyzer ✅ 0 findings
Authn/Authz Analyzer ❕ 20 findings
Configured Codepaths Analyzer ✅ 0 findings
Sensitive Files Analyzer ❕ 5 findings
Secrets Analyzer ✅ 0 findings

Note

🔴 Risk threshold exceeded. Adding a reviewer if one is configured in .dryrunsecurity.yaml.

notification list: @mtesauro @grendel513

Powered by DryRun Security

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik force-pushed the ruff_isort branch 2 times, most recently from 014fc1b to 635ec89 Compare March 25, 2024 21:36
@kiblik
Copy link
Contributor Author

kiblik commented Mar 26, 2024

This PR depends on #9823

@kiblik kiblik mentioned this pull request Mar 27, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik closed this Apr 17, 2024
@kiblik kiblik reopened this Apr 17, 2024
mtesauro
mtesauro approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik closed this Apr 26, 2024
@kiblik kiblik reopened this Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik closed this Apr 30, 2024
@kiblik kiblik reopened this Apr 30, 2024
@mtesauro mtesauro merged commit 134d403 into DefectDojo:dev Apr 30, 2024
237 of 238 checks passed
@kiblik kiblik deleted the ruff_isort branch April 30, 2024 20:57
dogboat pushed a commit to dogboat/django-DefectDojo that referenced this pull request May 6, 2024
@kiblik
Ruff: add isort (DefectDojo#9754)
873da73 
* Add isort

* Fix isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneill cneill cneill approved these changes

@mtesauro mtesauro mtesauro approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
apiv2 integration_tests parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kiblik @cneill @mtesauro @hblankenship @Maffooch