Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 restructure json in scout suite unittests #9874

Merged

Conversation

manuel-sommer
Copy link
Contributor

No description provided.

Copy link

dryrunsecurity bot commented Apr 3, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Authn/Authz Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@cneill
Copy link
Collaborator

cneill commented Apr 3, 2024

While you're tidying up these files, could you also rename them to .json instead of .js?

@manuel-sommer
Copy link
Contributor Author

While you're tidying up these files, could you also rename them to .json instead of .js?

The problem is then, that it looks like the content itself is invalid due to the first line scoutsuite_results = as it doesn't follow the json standard. Shall I do it nevertheless?

@cneill
Copy link
Collaborator

cneill commented Apr 4, 2024

While you're tidying up these files, could you also rename them to .json instead of .js?

The problem is then, that it looks like the content itself is invalid due to the first line scoutsuite_results = as it doesn't follow the json standard. Shall I do it nevertheless?

Apologies, I missed that bit in the big diff and didn't realize the parser was referencing a JS file produced as part of an HTML report.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@blakeaowens blakeaowens merged commit 0892763 into DefectDojo:dev Apr 8, 2024
120 checks passed
@manuel-sommer manuel-sommer deleted the scout_suite_unittestsrefactor branch April 9, 2024 01:38
hblankenship pushed a commit to hblankenship/django-DefectDojo that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants