Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove aws scout2 parser #9894

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

manuel-sommer
Copy link
Contributor

As we don't have a clear timeline for 3.X.X, we could remove awsscout2 parser earlier as the notification to merge to Scout2 was first published in January 2023.

@manuel-sommer
Copy link
Contributor Author

@Maffooch, this is a followup

Copy link

dryrunsecurity bot commented Apr 8, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings
AppSec Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Powered by DryRun Security

@manuel-sommer
Copy link
Contributor Author

I will not fix Ruff Linter here as this is already covered here: #9903

@mtesauro
Copy link
Contributor

@manuel-sommer That just got merged so hopefully it's no longer an issue for PRs 🤞

@manuel-sommer
Copy link
Contributor Author

Thank you for the hint @mtesauro . Rebasing is done.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@cneill
Copy link
Collaborator

cneill commented Apr 16, 2024

We can probably remove it here as well if we're removing the parser entirely. It looks like PARSER_EXCLUDE should work as expected even if its value is empty (ref).

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Apr 16, 2024
@manuel-sommer
Copy link
Contributor Author

Done @cneill, thank you for the hint.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mtesauro
Copy link
Contributor

@manuel-sommer This is ready to merge once the merge conflicts are fixed.

@manuel-sommer
Copy link
Contributor Author

Ready to get merged @mtesauro

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 3909492 into DefectDojo:dev May 1, 2024
123 checks passed
@manuel-sommer manuel-sommer deleted the rm_awsscout2parser branch May 1, 2024 03:23
dogboat pushed a commit to dogboat/django-DefectDojo that referenced this pull request May 6, 2024
* remove scout2 content

* remove aws_scout2 components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants