add test description for AWS SecurityHub Scan #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Powered by DryRun Security |
|
The rest of the Ruff Linter will be fixed here: https://github.com/DefectDojo/django-DefectDojo/pull/9903/files |
manuel-sommer
force-pushed
the
add_testdesc_for_awssechub
branch
from
119803f
to
db9e632
Compare
|
@manuel-sommer You might want to look at @cneill 's points in #9912 - not the same thing as you're doing here but also about adding items to the description of AWS Sec Hub |
|
I looked at the PR @mtesauro and reviewed it. |
cneill
requested changes
Apr 23, 2024
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
|
Done @cneill |
cneill
approved these changes
Apr 23, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
blakeaowens
approved these changes
May 2, 2024
Maffooch
approved these changes
May 2, 2024
dogboat
pushed a commit
to dogboat/django-DefectDojo
that referenced
this pull request
May 6, 2024
* add test description for AWS SecurityHub Scan * ruff, W293 * Update dojo/tools/awssecurityhub/parser.py Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com> * ruff --------- Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.