Make the number of request/response pairs returned by the API configurable #9967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🔴 Risk threshold exceeded. Adding a reviewer if one is configured in notification list: @mtesauro @grendel513 Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
github-actions
bot
added
settings_changes
Maffooch
approved these changes
Apr 20, 2024
cneill
changed the title
cneill
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Just a minor comment to make the environment variable's purpose a little clearer. I'm also not sure it makes sense to have a 0 value return 0 results here - I doubt anyone would want to force returning 0 req/resp pairs globally, but I'll leave that up to you to decide.
blakeaowens
approved these changes
Apr 22, 2024
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
cneill
approved these changes
Apr 22, 2024
hblankenship
added a commit
to hblankenship/django-DefectDojo
that referenced
this pull request
Apr 26, 2024
…rable (DefectDojo#9967) * limit req response via setting * add unittest * update running test documentation * also must do here * fix linting, add urls.py * trailing space in a comment... * switch back to finding - different test uses it * change test data to not break * reset data, use my own * Update dojo/settings/settings.dist.py Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com> --------- Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[sc-5238]
Implemented a new variable, DD_MAX_REQRESP_FROM_API, to allow a limit to the number of request/response pairs that are returned via the API. The default value is -1, meaning no limit to maintain current functionality.
Test results
Tested with multiple values for MAX_REQRESP_FROM_API: 5, 10, 18, 100, -1, -100
See included unittest for more
All tests pass
Documentation
Updated the DOCKER.md file to include updated instructions for running single or more tests in the container