Add a way to skip rpc checks #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1nt0ki
reviewed
Apr 25, 2024
| @@ -41,6 +41,9 @@ export class LlamaProvider extends FallbackProvider { | |||
| } | |||
|
|
|||
| async _ready() { | |||
| if(process.env["SKIP_RPC_CHECK"] === "true"){ | |||
There was a problem hiding this comment.
not a good idea since we will no longer be filtering out lagging or unreachable nodes. After this part, we never check if a rpc works or not, will lead to random failures
There was a problem hiding this comment.
isnt there a fallback provider that will keep trying rpcs if one fails?
There was a problem hiding this comment.
yeah, but if all3-5 are bad then...
There was a problem hiding this comment.
then wouldnt the call fail? which is the same result that we would have gotten otherwise, with an error about no rpcs being available
the difference would be if an rpc is stale, which your code will catch but if we skip setup we wont, but i think this would be ok since its the same behaviour we had before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.