Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalizeAddress #79

Merged
merged 4 commits into from
Oct 19, 2022
Merged

normalizeAddress #79

merged 4 commits into from
Oct 19, 2022

Conversation

waynebruce0x
Copy link
Contributor

wrt server comments

@waynebruce0x waynebruce0x mentioned this pull request Oct 14, 2022
Merged
@0xngmi
Copy link
Member

0xngmi commented Oct 19, 2022

lgtm, just some merge conflicts with package files

@0xngmi
Copy link
Member

0xngmi commented Oct 19, 2022

actually what about adding an even simpler function that is just address => address.startsWith("solana")?address:address.toLowerCase() and then replacing all the edge cases in coins-server with it?

@waynebruce0x waynebruce0x merged commit 243d094 into master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xngmi 0xngmi 0xngmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waynebruce0x @0xngmi