-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optimism and fixed to consider the chain in the unique pool test #1462
Conversation
Leoakin43
commented
Aug 13, 2024
- Add optimosm yields
- Fix the unique pool test to consider pool + chain
The moonwell adapter exports pools: Test Suites: 1 passed, 1 total
|
src/adaptors/test.js
Outdated
@@ -57,7 +57,7 @@ describe(`Running ${process.env.npm_config_adapter} Test`, () => { | |||
}); | |||
|
|||
test('Check for unique pool ids', () => { | |||
const poolIds = apy.map((pool) => pool.pool); | |||
const poolIds = apy.map((pool) => `${pool.pool}-${pool.chain}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong and needs to be reverted. u need to make sure that inside the adapter pool values are deduplicated. if u are using the same address multiple times on different chains u can add the chain suffix like u did, but it needs to be inside the adapter module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
The moonwell adapter exports pools: Test Suites: 1 passed, 1 total
|