🤖 Merge PR #45014 [callback-to-async-iterator] Fixes + allow usage of…

… listener return value in onClose by @affanshahid

allow usage of return val from listener in onClose

types/callback-to-async-iterator/callback-to-async-iterator-tests.ts

@@ -1,5 +1,9 @@
-import { callbackToAsyncIterator } from "callback-to-async-iterator";
+import callbackToAsyncIterator from "callback-to-async-iterator";
 
-callbackToAsyncIterator(() => {}); // $ExpectType AsyncIterator<unknown, any, undefined>
+callbackToAsyncIterator(async () => {}); // $ExpectType AsyncIterator<unknown, any, undefined>
 
-callbackToAsyncIterator<string>(() => {}); // $ExpectType AsyncIterator<string, any, undefined>
+callbackToAsyncIterator<string>(async () => {}); // $ExpectType AsyncIterator<string, any, undefined>
+
+callbackToAsyncIterator<string>(async () => {}, { onClose() {} }); // $ExpectType AsyncIterator<string, any, undefined>
+
+callbackToAsyncIterator<string, number>(async () => 1, { onClose(arg: number) {} });  // $ExpectType AsyncIterator<string, any, undefined>

types/callback-to-async-iterator/index.d.ts

@@ -1,16 +1,17 @@
 // Type definitions for callback-to-async-iterator 1.1
 // Project: https://github.com/withspectrum/callback-to-async-iterator#readme
 // Definitions by: Zachary Svoboda <https://github.com/zacnomore>
+//                 Affan Shahid <https://github.com/affanshahid>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 // Minimum TypeScript Version: 3.6
 
-export interface AsyncifyOptions<T> {
-    onClose: () => void | T;
-    onError: () => Error;
-    buffering: boolean;
+export interface AsyncifyOptions<T, R> {
+    onClose?: (arg: R) => void | T;
+    onError?: () => Error;
+    buffering?: boolean;
 }
 
-export function callbackToAsyncIterator<T>(
-    listener: (callback: (message: T) => void) => void,
-    options?: AsyncifyOptions<T>,
+export default function callbackToAsyncIterator<T, R = void>(
+    listener: (callback: (message: T) => void) => Promise<R>,
+    options?: AsyncifyOptions<T, R>,
 ): AsyncIterator<T>;