Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery: Export jQuery instead of $ #12616

Closed
wants to merge 1 commit into from

Conversation

Costo
Copy link

@Costo Costo commented Nov 11, 2016

Please fill in this template.

  • Prefer to make your PR against the types-2.0 branch.
  • Test the change in your own code.
  • Follow the advice from the readme.
  • Avoid common mistakes.

If changing an existing definition:

$ can conflict with other libraries in the global namespace (like angular-protractor). When that's the case, import statement like this don't work: import * as $ from 'jquery'.
Export jQuery instead of $ to avoid issues when importing jQuery.

$ can conflict with other libraries in the global namespace
@dt-bot
Copy link
Member

dt-bot commented Nov 11, 2016

jquery/index.d.ts

to authors (@borisyankov @choffmeister @Steve-Fenton @Diullei @tasoili @jasons-novaleaf @seanski @Guuz @ksummerlin @basarat @nwolverson @derekcicerone @AndrewGaspar @jameshfisher @seikichi @.benjaminjackman @s093294 @JoshStrobl @johnnyreilly @DickvdBrink). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@Costo
Copy link
Author

Costo commented Nov 11, 2016

This does not solve my problem after all. Still conflicting with aurelia-protractor... Closing

@Costo Costo closed this Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants