@types/node Class 'Module' incorrectly implements interface 'NodeModule'. #19601

egorshulga · 2017-09-07T08:38:43Z

I tried using the @types/node package and had problems.
Mention the authors (see Definitions by: in index.d.ts) so they can respond.
- Authors: @devoto13, @andy-ms

Compilation cannot succeed with the version 8.0.27 installed. The error is
node_modules/@types/node/index.d.ts(5615,11): error TS2420: Class 'Module' incorrectly implements interface 'NodeModule'. Property 'hot' is missing in type 'Module'.

Version 8.0.26 does not have this error.

The text was updated successfully, but these errors were encountered:

ldrick · 2017-09-07T08:47:17Z

Perfect, thanks, was quite in this moment writing the same issue. This seems to be an conflict with @types/webpack-env

devoto13 · 2017-09-07T08:51:12Z

My guess would be that somewhere in the project you augment NodeModule definition by adding hot property in it. I added Module class, which implements NodeModule recently. and it obviously doesn't have this new property added because of the augmentation.

As a temporary fix you can either remove augmentation ~~or add something like below (haven't actually tested it)~~. Or just pin version to 8.0.26 until it's fixed.

(incorrect code removed)

I'll submit a PR to fix this issue soon.

This causes type errors, when people augment NodeModule intefrace by adding more properties to it. Which seems to be pretty common in a wild. Fixes DefinitelyTyped#19601

burabure · 2017-09-13T19:23:10Z

still getting the same error. It seems you NEED to add @types/webpack-env to package.json in order to fix this

ghost · 2017-09-14T15:28:00Z

@burabure The contents of your package.json shouldn't affect TypeScript -- although the contents of node_modules does. Having just @types/node installed without @types/webpack-env doesn't reproduce the error for me, nor does having both installed. Maybe you fixed your error by updating webpack-env?

burabure · 2017-09-14T16:26:24Z

ok the issue was that another of my deps @types/storybook__react had a dependecy on the old @types/webpack-env

micahgodbolt · 2017-09-14T21:22:42Z

@burabure what was your solution. I'm in the same boat. Just remove webpack-env, as storybook will bring it in as a dependency?

burabure · 2017-09-15T00:08:04Z

@micahgodbolt I did yarn remove @types/node @types/storybook__react && yarn add -D @types/node @types/storybook__react but updating those might do the job also

sentilesdal · 2020-02-04T20:44:14Z

@burabure, @micaelmbagira I was able to solve this problem by downgrading @types/webpack-env to 1.14.1.

neilpoulin · 2020-04-30T03:36:28Z

I had this same issue, although with a slightly different error message. Downgrading to @types/webpack-env@1.14.1 as @sentilesdal suggested did the trick for me.

Below was my error when running tsc. This problem started after I added storybook to my project. I also ended up downgrading my Note types to @types/node@12.12.6. I'm not sure what specifically solved the problem, but with those two settings, I was able to get things working.

Here's the error:

node_modules/@types/webpack-env/index.d.ts:349:15 - error TS2430: Interface 'NodeJS.Module' incorrectly extends interface '__WebpackModuleApi.Module'.
  Types of property 'parent' are incompatible.
    Type 'Module | null' is not assignable to type 'NodeModule | null'.
      Type 'Module' is not assignable to type 'NodeModule'.
        Property 'hot' is optional in type 'Module' but required in type 'NodeModule'.
 

 
349     interface Module extends __WebpackModuleApi.Module {}

sinoon · 2020-07-07T06:19:17Z

for the get type error buddy, you can add "types": ["@types/node"] to project tsconfig.js, it means that only the type listed it will import in the type system.

ferm10n · 2020-09-14T23:12:36Z

My team also ran into this issue, and downgrading @types/webpack-env did not help.

Instead, we were able to resolve it by rolling back @types/node@14.10.1 to @types/node@14.0.27

sanex3339 · 2020-09-15T18:57:49Z

Same problem with @types/node@14.10.1 and above

Shinigami92 · 2020-09-16T08:31:28Z

Having this problem with @types/node@14.10.1 but not with @types/node@14.10.0 !!!
Just a bugfix release turns out to be a breaking change 👀

sandersn · 2020-09-16T15:22:41Z

DT piggy-backs on semver, so you should specify exact versions of @types packages:
https://github.com/DefinitelyTyped/DefinitelyTyped#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library

ferm10n · 2020-09-16T16:05:59Z

@sandersn So maybe those of us who are affected should try to target the packages that use @types/node instead?

I could see that leading to having multiple installs of @types/node at slightly different versions, I'm not familiar enough with how these types are used to determine if that'd be an issue but I'd expect it to be fine.

DefinitelyTyped/DefinitelyTyped#19601

Shinigami92 · 2020-09-18T07:45:41Z

Works again with 14.11.1 as if nothing had ever happened 🤷‍♂️

cefjic · 2020-09-21T12:52:46Z

I have the error Interface 'NodeJS.Module' incorrectly extends interface '__WebpackModuleApi.Module'. on v14.11.1

ferm10n · 2020-09-21T13:03:33Z

What are the odds that there's different versions of the same package?

Here's an idea to help us figure things out. For anyone experiencing this problem currently and in future:

npm ci to do a clean install
verify the error is still present
comment and attach your project's package-lock and tsconfig (remove sensitive stuff if needed)

tobilen · 2020-09-22T15:58:42Z

Same issue with 14.11.2 in my project. Tried downgrading to 14.11.1 and then 14.11.0, same issue.

Working tree (including lockfile and package.json) -> https://github.com/ivx/react-skeletons/tree/d3ffc9fbbcf3f7c08a230e9c287a55b53d785ac7
CI Result: https://app.circleci.com/pipelines/github/ivx/react-skeletons/83/workflows/11182212-cb51-432b-9653-cf5cca0f22eb/jobs/216

Resolved it by removing @types/node since i didn't need it anymore. Output of yarn why @types/node might be interesting:

$ yarn why @types/node
yarn why v1.22.4
[1/4] Why do we have the module "@types/node"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "@types/node@14.11.0"
info Has been hoisted to "@types/node"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "824KB"
info Disk size with unique dependencies: "824KB"
info Disk size with transitive dependencies: "824KB"
info Number of shared dependencies: 0
=> Found "@jest/types#@types/node@13.13.5"
info This module exists because "@jest#types" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@jest/core#@types/node@13.13.5"
info This module exists because "jest#@jest#core" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-util#@types/node@13.13.5"
info This module exists because "ts-jest#jest-util" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@jest/console#@types/node@13.13.5"
info This module exists because "jest#@jest#core#@jest#console" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@types/node-fetch#@types/node@13.13.5"
info This module exists because "@storybook#react#@storybook#core#@types#node-fetch" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-haste-map#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-haste-map" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-runner#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-runner" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-watcher#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-watcher" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@jest/environment#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-runner#@jest#environment" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@jest/fake-timers#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-runtime#@jest#fake-timers" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@types/glob#@types/node@13.13.5"
info This module exists because "@storybook#react#@storybook#core#glob-promise#@types#glob" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@types/graceful-fs#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-haste-map#@types#graceful-fs" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@types/webpack#@types/node@13.13.5"
info This module exists because "@storybook#react#@storybook#core#html-webpack-plugin#@types#webpack" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-environment-jsdom#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-config#jest-environment-jsdom" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-environment-node#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-config#jest-environment-node" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-jasmine2#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-config#jest-jasmine2" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-mock#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-runtime#jest-mock" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-serializer#@types/node@13.13.5"
info This module exists because "jest#@jest#core#jest-haste-map#jest-serializer" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "jest-worker#@types/node@13.13.5"
info This module exists because "@storybook#react#@storybook#core#terser-webpack-plugin#jest-worker" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
=> Found "@types/webpack-sources#@types/node@13.13.5"
info This module exists because "@storybook#react#@storybook#core#html-webpack-plugin#@types#webpack#@types#webpack-sources" depends on it.
info Disk size without dependencies: "820KB"
info Disk size with unique dependencies: "820KB"
info Disk size with transitive dependencies: "820KB"
info Number of shared dependencies: 0
Done in 0.55s.

Elvin1492 · 2020-11-27T23:36:18Z

The solution which is worked for me

npm ci
downgrade version ->npm i @types@{your version}
npm cache clean

Done

DefinitelyTyped/DefinitelyTyped#19601

devoto13 mentioned this issue Sep 7, 2017

Removed implements NodeModule clause from Module class #19602

Closed

8 tasks

rhonsby mentioned this issue Sep 7, 2017

Updates hot property in Module interface to optional #19613

Merged

8 tasks

sandersn closed this as completed in #19613 Sep 7, 2017

molnarzs added a commit to garlictech/workflows that referenced this issue Sep 9, 2017

fix: Workaround for DefinitelyTyped/DefinitelyTyped#19601

2bf8c69

kemalcany mentioned this issue Oct 2, 2017

[@types/node": "8.0.31] Class 'Module' incorrectly implements interface 'NodeModule'. #20158

Closed

KimWooHyun mentioned this issue May 21, 2018

@types/node Interface 'NodeModule' incorrectly extends interface 'Module'. #25908

Closed

3 tasks

g1eny0ung added a commit to seagreenio/react-bulma that referenced this issue Sep 17, 2020

Pin @types/node to 14.0.27

db6087a

DefinitelyTyped/DefinitelyTyped#19601

apust mentioned this issue Sep 21, 2020

Pin @types/node to 14.0.27 cft-group/elephas-react#124

Merged

g1eny0ung added a commit to seagreenio/react-bulma that referenced this issue Feb 16, 2021

Pin @types/node to 14.0.27

e9e8dae

DefinitelyTyped/DefinitelyTyped#19601

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@types/node Class 'Module' incorrectly implements interface 'NodeModule'. #19601

@types/node Class 'Module' incorrectly implements interface 'NodeModule'. #19601

egorshulga commented Sep 7, 2017 •

edited

ldrick commented Sep 7, 2017 •

edited

devoto13 commented Sep 7, 2017 •

edited

burabure commented Sep 13, 2017 •

edited

ghost commented Sep 14, 2017

burabure commented Sep 14, 2017 •

edited

micahgodbolt commented Sep 14, 2017

burabure commented Sep 15, 2017

sentilesdal commented Feb 4, 2020

neilpoulin commented Apr 30, 2020

sinoon commented Jul 7, 2020

ferm10n commented Sep 14, 2020

sanex3339 commented Sep 15, 2020

Shinigami92 commented Sep 16, 2020

sandersn commented Sep 16, 2020

ferm10n commented Sep 16, 2020

Shinigami92 commented Sep 18, 2020

cefjic commented Sep 21, 2020 •

edited

ferm10n commented Sep 21, 2020

tobilen commented Sep 22, 2020 •

edited

Elvin1492 commented Nov 27, 2020

@types/node Class 'Module' incorrectly implements interface 'NodeModule'. #19601

@types/node Class 'Module' incorrectly implements interface 'NodeModule'. #19601

Comments

egorshulga commented Sep 7, 2017 • edited

ldrick commented Sep 7, 2017 • edited

devoto13 commented Sep 7, 2017 • edited

burabure commented Sep 13, 2017 • edited

ghost commented Sep 14, 2017

burabure commented Sep 14, 2017 • edited

micahgodbolt commented Sep 14, 2017

burabure commented Sep 15, 2017

sentilesdal commented Feb 4, 2020

neilpoulin commented Apr 30, 2020

sinoon commented Jul 7, 2020

ferm10n commented Sep 14, 2020

sanex3339 commented Sep 15, 2020

Shinigami92 commented Sep 16, 2020

sandersn commented Sep 16, 2020

ferm10n commented Sep 16, 2020

Shinigami92 commented Sep 18, 2020

cefjic commented Sep 21, 2020 • edited

ferm10n commented Sep 21, 2020

tobilen commented Sep 22, 2020 • edited

Elvin1492 commented Nov 27, 2020

egorshulga commented Sep 7, 2017 •

edited

ldrick commented Sep 7, 2017 •

edited

devoto13 commented Sep 7, 2017 •

edited

burabure commented Sep 13, 2017 •

edited

burabure commented Sep 14, 2017 •

edited

cefjic commented Sep 21, 2020 •

edited

tobilen commented Sep 22, 2020 •

edited