Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI build doesn't fail builds with missing test files. #2974

Closed
akalman opened this issue Oct 14, 2014 · 4 comments
Closed

Travis CI build doesn't fail builds with missing test files. #2974

akalman opened this issue Oct 14, 2014 · 4 comments

Comments

@akalman
Copy link
Contributor

akalman commented Oct 14, 2014

No description provided.

@Bartvds
Copy link
Collaborator

Bartvds commented Nov 16, 2014

Can you expand on this? We're aware many defs have no test, so it reports them but doesn't fail the build.

@akalman
Copy link
Contributor Author

akalman commented Nov 16, 2014

Well the main problem I encountered was I was able to write new definition files without test coverage, and nothing stopped me.

Its true that there are a lot of definitions that are missing tests, I'm just concerned with making sure all new definitions do have tests.

@Bartvds
Copy link
Collaborator

Bartvds commented Nov 16, 2014

Currently it is up to the merging collaborator to verify there are tests for new files, but I made a note to add a check to the tester. DefinitelyTyped/definition-tester#9

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants