-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI build doesn't fail builds with missing test files. #2974
Comments
Can you expand on this? We're aware many defs have no test, so it reports them but doesn't fail the build. |
Well the main problem I encountered was I was able to write new definition files without test coverage, and nothing stopped me. Its true that there are a lot of definitions that are missing tests, I'm just concerned with making sure all new definitions do have tests. |
Currently it is up to the merging collaborator to verify there are tests for new files, but I made a note to add a check to the tester. DefinitelyTyped/definition-tester#9 |
Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the |
No description provided.
The text was updated successfully, but these errors were encountered: